Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for devs to create debug images from PRs #115

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

mallardduck
Copy link
Member

Per the title, this does what it says.

After merge we'll have a workflow we can navigate to under "Actions". And once there we can type, or paste, in a PR number. The workflow will then check out that PR and identify the current head commit for it. Then it will produce a dev/debug image for the changes included in that PR and push to ghcr.io.

This can be helpful for quickly testing the changes in a PR before merge. And given that the images only exist on GHCR.io it will not pollute the dockerhub. So it should be relatively low risk to introduce these dev focused images without confusing them with customer/end-user ones in docker hub.

Once the workflow completes it should update the PR with a comment and links to the images with the names of the tags it produced. Any subsequent image for the same PR will use the same rolling tag, but all past images will exist at static tags correlated to their commit hash too.

@mallardduck
Copy link
Member Author

Example comment here: mallardduck#2 (comment)

@mallardduck mallardduck marked this pull request as ready for review October 25, 2024 16:59
@mallardduck mallardduck requested a review from a team as a code owner October 25, 2024 16:59
@mallardduck mallardduck requested review from jbiers and removed request for jbiers October 25, 2024 16:59
@mallardduck mallardduck merged commit d7a465b into rancher:main Oct 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant