Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC WithBlock is deprecated #488

Open
salasberryfin opened this issue Oct 29, 2024 · 0 comments · May be fixed by #490
Open

gRPC WithBlock is deprecated #488

salasberryfin opened this issue Oct 29, 2024 · 0 comments · May be fixed by #490
Labels
kind/bug Something isn't working

Comments

@salasberryfin
Copy link
Contributor

salasberryfin commented Oct 29, 2024

Description

Etcd NewClient uses the gRPC call WithBlock, which has now been deprecated and is considered an anti-pattern:

DialOptions: []grpc.DialOption{
grpc.WithBlock(), // block until the underlying connection is up
grpc.WithContextDialer(dialer.DialContextWithAddr),
},

More information on why this is the case can be found in the grpc-go documentation here

@salasberryfin salasberryfin added the kind/bug Something isn't working label Oct 29, 2024
@salasberryfin salasberryfin linked a pull request Oct 31, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

Successfully merging a pull request may close this issue.

1 participant