Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document use of curl::form_data in POST #667

Closed
kent37 opened this issue Jul 27, 2020 · 1 comment
Closed

Document use of curl::form_data in POST #667

kent37 opened this issue Jul 27, 2020 · 1 comment

Comments

@kent37
Copy link

kent37 commented Jul 27, 2020

Since c8f7a69 fixed #430, the body parameter of httr::POST may contain form elements created with curl::form_data. Unfortunately this is not mentioned in the documentation for POST. I suggest changing the help text at

httr/R/http-post.r

Lines 22 to 23 in cb4e20c

#' For "multipart", list elements can be strings or objects created by
#' [upload_file()]. For "form", elements are coerced to strings

to

#'   For "multipart", list elements can be strings or objects created by
#'   [upload_file()] or [curl::form_data()]. For "form", elements are coerced to strings

to make it easier to discover this useful functionality. Thank you!

@hadley
Copy link
Member

hadley commented Oct 31, 2023

httr has been superseded in favour of httr2, so is no longer under active development. If this problem is still important to you in httr2, I'd suggest filing an issue offer there 😄 (but it looks like it's already documented). Thanks for using httr!

@hadley hadley closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants