-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to missing scheme handling (defaults to http) #620
Conversation
Thanks ! I am just wondering if we should assume that any parse url without scheme should be Also, I wonder if this type of fix (if scheme is null, assume http) should be better in Just sharing thoughts to help decide what is best. |
the standard behaviour of web-browsers et al. is to default to http when no scheme is provided. and it would be consistent with the earlier versions of
oh yeah, that's a fair point. i'll make that change. with thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a bullet to the top of NEWS.md
? It should briefly describe the change and end with (@yourname, #issuenumber)
.
I have an issue reported in {robotstxt} directly related to this PR and also solved by this PR. Will this PR be included in httr at some time in the future? |
We don't have any plans to spin off a httr release at the moment. |
Thanks, for the heads up. |
httr has been superseded in favour of httr2, so is no longer under active development. Thanks for using httr, thanks for contributing, and my apologies that your contribution never made it into the package. |
Fixes #619
Fixes #607