Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper macOS support for API identities #542

Open
megastep opened this issue Sep 17, 2024 · 7 comments
Open

Proper macOS support for API identities #542

megastep opened this issue Sep 17, 2024 · 7 comments

Comments

@megastep
Copy link

megastep commented Sep 17, 2024

I have several universal iOS / macOS apps (not Catalyst - separate apps with a common code base). When running the macOS version, I get a bunch of these errors in the console:

❌ Request failed: https://api.qonversion.io/v2/identities, error: Error Domain=com.qonversion.io.api Code=3 "wrong platform" UserInfo={NSLocalizedDescription=wrong platform}

I believe the SDK sends the "macOS" platform to the API, which in turn returns this failure. This creates downstream issues as I think it prevents my users from being identified properly and re-associated with their other accounts.

It sounds like an easy fix would be to simply allow the backend to recognize macOS platform values, as otherwise all of the SDK compiles and is functional, and can process purchases, etc.

@megastep
Copy link
Author

In a fork, I tried manually overriding the platform values defined in QNINternalConstants.m.

The errors go away if I make it pretend to be iOS - doesn't work even with the macCatalyst values. I may have to keep using this fork as a workaround in the meantime.

@suriksarkisyan
Copy link
Contributor

Hi, @megastep
I will discuss with the team and get back to you as soon as there are any updates!

Copy link
Contributor

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the awaiting answers There is no activity for a while label Sep 25, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

@megastep
Copy link
Author

was there any resolution on this?

@SpertsyanKM SpertsyanKM reopened this Sep 30, 2024
@SpertsyanKM SpertsyanKM added investigating and removed awaiting answers There is no activity for a while labels Sep 30, 2024
@suriksarkisyan
Copy link
Contributor

Hello, @megastep . The solution you provided above will work for now, even though it’s not ideal. The issue is that you need to ensure this change isn’t lost after the pod install. As for a proper solution, I’ve passed the task to the team to fix the problem. I can’t say exactly when it will be ready, but I will definitely get back to you with an update as soon as we release the fix.

@megastep
Copy link
Author

I am using my patched fork with the Swift Package Manager so no worries for now. I'd love to know when I can safely switch back to the mainstream package though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants