Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Warn when setting qmk_{firmware,userspace} paths if they contain spaces #167

Open
agsimmons opened this issue Dec 17, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@agsimmons
Copy link

Description

Due to make and possibly other build build tools used for qmk, a space in your paths to qmk_firmware or qmk_userspace can cause compilation to fail. Specifically, I had no issue with a space in my path until I started using External Userspace. While using External Userspace with a space in the path for both qmk_firmware and qmk_userspace, qmk compile and qmk userspace-compile fail with unhelpful errors.

While it may not be possibly to fully support spaces in paths, it might be a good idea to not allow spaces in paths to begin with. That could be enforced at the qmk_cli level. When user.qmk_home or user.overlay_dir are set, there could be a check for spaces, and an error if they are present.

@agsimmons agsimmons added the enhancement New feature or request label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant