Fix parsing 2-byte LAS scan angle (fix #58451) #58963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uclaros
reviewed
Oct 4, 2024
uclaros
added
Bug
Thanks for the review! I admit I (ab)use GitHub's CI to show me which tests need attention, since I get too many false positives on my machine. They should all be fixed now. |
uclaros
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently in QGIS the
ScanAngleRankLAS(/LAZ) field is typed as a short and is read as a single signed byte. The LAS 1.4 specification introduced a new field,ScanAngle, which is logically a two-byte fixed-point number, to replaceScanAngleRankin new formats. Right now QGIS tries to read this field asScanAngleRank, so the result is an incorrect integer value.This PR changes the type of
ScanAngleRanktofloatand fixes parsing the new LAS 1.4 formats, unifyingScanAngleRankandScanAngleinto one general property, just as PDAL does.Will fix #58451.