-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple Clang 16 build issue, requires ld_classic #8653
Comments
We implemented a compiler wrapper in Spack that removes duplicate RPATHs, but we're still seeing the following issue:
It's possible the bug is in PyTorch itself, but I'm not familiar enough with CMake to report it. |
Sorry @adamjstewart , this is kind of tricky to fix because we build torchvision on some subset of compilers, and that means not all may be properly supported. Especially in this case where the compiler/linker seems to be more pedantic than gcc (which tends to silently just ignore anything it doesn't expect). |
This is funny because Google (TF, JAX) have now dropped support for GCC and only support Clang. But I understand the pain of having to support too many compilers/platforms/etc. Ideally someone with more experience with Clang than both of us can submit a patch. I'm still not 100% convinced that this isn't a bug in Spack's compiler wrappers, so if no one else reports this issue, I wouldn't prioritize it too much. |
🐛 Describe the bug
When building from source with the new Apple Clang 16, I see the following error:
Current workaround is to inject
-Wl,-ld_classic
into the linker, but would be good to fix this asld_classic
is deprecated and will be removed in the future.Versions
The text was updated successfully, but these errors were encountered: