From f5f911b48473ecec6549627d0cbead9fadbe57fb Mon Sep 17 00:00:00 2001
From: Evan Smothers <ebs@fb.com>
Date: Mon, 8 Jul 2024 18:01:03 -0700
Subject: [PATCH 01/10] [wip] CI: drop 3.8, run on ao nightly, better ao
 version checks

---
 .github/workflows/recipe_test.yaml            |  2 +-
 .github/workflows/recipe_test_multi_gpu.yaml  |  2 +-
 .github/workflows/recipe_test_nightly.yaml    |  8 +++-
 .github/workflows/unit_test.yaml              |  2 +-
 pyproject.toml                                |  2 +-
 .../_register_nf4_dispatch_ops.py             | 24 +++-------
 torchtune/modules/low_precision/_utils.py     | 45 +++++++++++++++++++
 7 files changed, 62 insertions(+), 23 deletions(-)
 create mode 100644 torchtune/modules/low_precision/_utils.py

diff --git a/.github/workflows/recipe_test.yaml b/.github/workflows/recipe_test.yaml
index 39157c321e..b5974efc60 100644
--- a/.github/workflows/recipe_test.yaml
+++ b/.github/workflows/recipe_test.yaml
@@ -24,7 +24,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11']
+        python-version: ['3.9', '3.10', '3.11']
     steps:
       - name: Check out repo
         uses: actions/checkout@v3
diff --git a/.github/workflows/recipe_test_multi_gpu.yaml b/.github/workflows/recipe_test_multi_gpu.yaml
index d62bcc81bc..0efa2c9cdd 100644
--- a/.github/workflows/recipe_test_multi_gpu.yaml
+++ b/.github/workflows/recipe_test_multi_gpu.yaml
@@ -23,7 +23,7 @@ jobs:
     runs-on: linux.8xlarge.nvidia.gpu
     strategy:
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11']
+        python-version: ['3.9', '3.10', '3.11']
         torch-version: ["stable"]
     steps:
       - name: Check out repo
diff --git a/.github/workflows/recipe_test_nightly.yaml b/.github/workflows/recipe_test_nightly.yaml
index d0f3cd0941..d5abd4caba 100644
--- a/.github/workflows/recipe_test_nightly.yaml
+++ b/.github/workflows/recipe_test_nightly.yaml
@@ -4,6 +4,7 @@ on:
   schedule:
     # Runs at midnight every day
     - cron:  '0 0 * * *'
+  workflow_dispatch:
 
 concurrency:
   group: recipe-test-nightly-${{ github.workflow }}-${{ github.ref == 'refs/heads/main' && github.run_number || github.ref }}
@@ -22,7 +23,7 @@ jobs:
     runs-on: linux.8xlarge.nvidia.gpu
     strategy:
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11']
+        python-version: ['3.9', '3.10', '3.11']
         torch-version: ["stable", "nightly"]
     steps:
       - name: Check out repo
@@ -38,7 +39,7 @@ jobs:
         run: python -m pip install --upgrade pip
       - name: Install torch nightly
         if: ${{ matrix.torch-version == 'nightly' }}
-        run: python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu118
+        run: python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu121
       - name: Install torch stable
         if: ${{ matrix.torch-version == 'stable' }}
         run: python -m pip install torch
@@ -46,6 +47,9 @@ jobs:
         run: |
           python -m pip install -e ".[dev]"
           python -m pip install lm-eval==0.4.*
+      - name: Install torchao nightly
+        if: ${{ matrix.torch-version == 'nightly' }}
+        pip install --pre torchao-nightly --index-url https://download.pytorch.org/whl/nightly/cu121
       - name: Run recipe tests with coverage
         run: pytest tests -m integration_test --cov=. --cov-report=xml --durations=20 -vv
       - name: Upload Coverage to Codecov
diff --git a/.github/workflows/unit_test.yaml b/.github/workflows/unit_test.yaml
index eb7dfe42e5..6a9c83e1ed 100644
--- a/.github/workflows/unit_test.yaml
+++ b/.github/workflows/unit_test.yaml
@@ -18,7 +18,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11']
+        python-version: ['3.9', '3.10', '3.11']
     steps:
       - name: Check out repo
         uses: actions/checkout@v3
diff --git a/pyproject.toml b/pyproject.toml
index 6d4d8230e3..e79f999ccc 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -3,7 +3,7 @@
 name = "torchtune"
 description = "A native-PyTorch library for LLM fine-tuning"
 readme = "README.md"
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 license = {file = "LICENSE"}
 authors = [
     { name = "PyTorch Team", email = "packages@pytorch.org" },
diff --git a/torchtune/modules/low_precision/_register_nf4_dispatch_ops.py b/torchtune/modules/low_precision/_register_nf4_dispatch_ops.py
index 8c85d928f2..b057a1fbc3 100644
--- a/torchtune/modules/low_precision/_register_nf4_dispatch_ops.py
+++ b/torchtune/modules/low_precision/_register_nf4_dispatch_ops.py
@@ -4,14 +4,9 @@
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
-from importlib.metadata import PackageNotFoundError, version
-
 import torch
 from torchao.dtypes.nf4tensor import implements as nf4_tensor_impl, to_nf4
-
-
-def is_fbcode():
-    return not hasattr(torch.version, "git_version")
+from torchtune.modules.low_precision._utils import _get_torchao_version
 
 
 @nf4_tensor_impl([torch.ops.aten.clone.default])
@@ -26,17 +21,12 @@ def clone(func, *args, **kwargs):
 
 
 should_define_inplace_copy = True
-if not is_fbcode():
-    try:
-        ao_version = version("torchao")
-        should_define_inplace_copy = ao_version < "0.2.0"
-    # For importlib metadata, need to check nightly separately
-    except PackageNotFoundError:
-        ao_version = version("torchao-nightly")
-        should_define_inplace_copy = ao_version < "2024.5.20"
-    except Exception as e:
-        raise PackageNotFoundError("Could not find torchao version") from e
-
+ao_version, is_nightly = _get_torchao_version()
+if ao_version:
+    if (is_nightly and ao_version >= "2024.5.20") or (
+        not is_nightly and ao_version >= "0.2.0"
+    ):
+        should_define_inplace_copy = False
 
 if should_define_inplace_copy:
     # TorchAO have `NF4.copy_` starting from `0.2.0`
diff --git a/torchtune/modules/low_precision/_utils.py b/torchtune/modules/low_precision/_utils.py
new file mode 100644
index 0000000000..ee4cce0cbd
--- /dev/null
+++ b/torchtune/modules/low_precision/_utils.py
@@ -0,0 +1,45 @@
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+# All rights reserved.
+#
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+from importlib.metadata import PackageNotFoundError, version
+
+import torchao
+
+
+def _is_fbcode():
+    return not hasattr(torch.version, "git_version")
+
+
+def _get_torchao_version() -> Tuple[Optional[str], Optional[str]]:
+    """
+    Get torchao version. Returns a tuple of two elements, the first element
+    is the version string, the second element is whether it's a nightly version.
+    For fbcode usage, return None, None.
+
+    Checks:
+        1) is_fbcode, then
+        2) torchao.__version__ (only defined for torchao >= 0.3.0), then
+        3) importlib's version(torchao) for non-nightly, then
+        4) importlib's version(torchao-nightly) for nightlies
+
+    If none of these work, raise an error.
+
+    """
+    if _is_fbcode():
+        return None, None
+    try:
+        ao_version = torchao.__version__
+        is_nightly = False
+    except AttributeError:
+        ao_version = version("torchao")
+        is_nightly = False
+    # For importlib metadata, need to check nightly separately
+    except PackageNotFoundError:
+        ao_version = version("torchao-nightly")
+        is_nightly = True
+    except Exception as e:
+        raise PackageNotFoundError("Could not find torchao version") from e
+    return ao_version, is_nightly

From 4c4de97782cedda53af87e90177d1afabcde12f1 Mon Sep 17 00:00:00 2001
From: Evan Smothers <ebs@fb.com>
Date: Mon, 8 Jul 2024 18:03:44 -0700
Subject: [PATCH 02/10] run unit tests on GPUs in CI

---
 .../{recipe_test_multi_gpu.yaml => gpu_test.yaml}      | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
 rename .github/workflows/{recipe_test_multi_gpu.yaml => gpu_test.yaml} (80%)

diff --git a/.github/workflows/recipe_test_multi_gpu.yaml b/.github/workflows/gpu_test.yaml
similarity index 80%
rename from .github/workflows/recipe_test_multi_gpu.yaml
rename to .github/workflows/gpu_test.yaml
index 0efa2c9cdd..ce76ea03ec 100644
--- a/.github/workflows/recipe_test_multi_gpu.yaml
+++ b/.github/workflows/gpu_test.yaml
@@ -1,4 +1,4 @@
-name: Multi-GPU Recipe Tests
+name: GPU tests
 
 on:
   push:
@@ -7,7 +7,7 @@ on:
   workflow_dispatch:
 
 concurrency:
-  group: recipe-test-multi-gpu-${{ github.workflow }}-${{ github.ref == 'refs/heads/main' && github.run_number || github.ref }}
+  group: gpu-test-${{ github.workflow }}-${{ github.ref == 'refs/heads/main' && github.run_number || github.ref }}
   cancel-in-progress: true
 
 permissions:
@@ -19,7 +19,7 @@ defaults:
     shell: bash -l -eo pipefail {0}
 
 jobs:
-  recipe_test_multi_gpu:
+  gpu_test:
     runs-on: linux.8xlarge.nvidia.gpu
     strategy:
       matrix:
@@ -47,7 +47,7 @@ jobs:
         run: |
           python -m pip install -e ".[dev]"
           python -m pip install lm-eval==0.4.*
-      - name: Run recipe tests with coverage
-        run: pytest tests -m integration_test --cov=. --cov-report=xml --durations=20 -vv
+      - name: Run recipe and unit tests with coverage
+        run: pytest tests --with-integration --cov=. --cov-report=xml --durations=20 -vv
       - name: Upload Coverage to Codecov
         uses: codecov/codecov-action@v3

From e85fe964614624b9f54b250b27d8ca475ab26dfd Mon Sep 17 00:00:00 2001
From: Evan Smothers <ebs@fb.com>
Date: Mon, 8 Jul 2024 21:24:05 -0700
Subject: [PATCH 03/10] cleanup

---
 .github/workflows/recipe_test.yaml         |  2 +-
 .github/workflows/recipe_test_nightly.yaml |  4 +--
 .github/workflows/regression_test.yaml     |  4 +--
 .github/workflows/unit_test.yaml           |  2 +-
 README.md                                  | 11 ++++++-
 pyproject.toml                             |  2 --
 torchtune/modules/low_precision/_utils.py  | 34 +++++++++++++---------
 torchtune/utils/quantization.py            | 10 ++++++-
 8 files changed, 46 insertions(+), 23 deletions(-)

diff --git a/.github/workflows/recipe_test.yaml b/.github/workflows/recipe_test.yaml
index b5974efc60..852f34beaf 100644
--- a/.github/workflows/recipe_test.yaml
+++ b/.github/workflows/recipe_test.yaml
@@ -39,7 +39,7 @@ jobs:
         run: python -m pip install --upgrade pip
       - name: Install dependencies
         run: |
-          python -m pip install torch
+          python -m pip install torch torchvision
           python -m pip install -e ".[dev]"
           python -m pip install lm-eval==0.4.*
       - name: Run recipe tests with coverage
diff --git a/.github/workflows/recipe_test_nightly.yaml b/.github/workflows/recipe_test_nightly.yaml
index d5abd4caba..a9e33da110 100644
--- a/.github/workflows/recipe_test_nightly.yaml
+++ b/.github/workflows/recipe_test_nightly.yaml
@@ -39,10 +39,10 @@ jobs:
         run: python -m pip install --upgrade pip
       - name: Install torch nightly
         if: ${{ matrix.torch-version == 'nightly' }}
-        run: python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu121
+        run: python -m pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu121
       - name: Install torch stable
         if: ${{ matrix.torch-version == 'stable' }}
-        run: python -m pip install torch
+        run: python -m pip install torch torchvision
       - name: Install remaining dependencies
         run: |
           python -m pip install -e ".[dev]"
diff --git a/.github/workflows/regression_test.yaml b/.github/workflows/regression_test.yaml
index 1a82add1af..7ea639aebd 100644
--- a/.github/workflows/regression_test.yaml
+++ b/.github/workflows/regression_test.yaml
@@ -47,10 +47,10 @@ jobs:
           python3 -m pip install awscli==1.32.6
       - name: Install torch nightly
         if: ${{ matrix.torch-version == 'nightly' }}
-        run: python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu118
+        run: python -m pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu118
       - name: Install torch stable
         if: ${{ matrix.torch-version == 'stable' }}
-        run: python -m pip install torch
+        run: python -m pip install torch torchvision
       - name: Install remaining dependencies
         run: |
           python -m pip install -e ".[dev]"
diff --git a/.github/workflows/unit_test.yaml b/.github/workflows/unit_test.yaml
index 6a9c83e1ed..706bf37860 100644
--- a/.github/workflows/unit_test.yaml
+++ b/.github/workflows/unit_test.yaml
@@ -33,7 +33,7 @@ jobs:
         run: python -m pip install --upgrade pip
       - name: Install dependencies
         run: |
-          python -m pip install torch
+          python -m pip install torch torchvision
           python -m pip install -e ".[dev]"
       - name: Run unit tests with coverage
         run: pytest tests --cov=. --cov-report=xml --durations=20 -vv
diff --git a/README.md b/README.md
index 4b05f775ef..240bcd061a 100644
--- a/README.md
+++ b/README.md
@@ -156,7 +156,16 @@ You can find a full list of all our Llama3 configs [here.](recipes/configs/llama
 
 ## Installation
 
-**Step 1:** [Install PyTorch](https://pytorch.org/get-started/locally/). torchtune is tested with the latest stable PyTorch release as well as the preview nightly version.
+**Step 1:** [Install PyTorch](https://pytorch.org/get-started/locally/). torchtune is tested with the latest stable PyTorch release as well as the preview nightly version. For multimodality
+be sure to also install torchvision.
+
+```
+# Install stable version of PyTorch using pip
+pip3 install torch torchvision
+
+# Nightly install for latest features
+pip3 install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu121
+```
 
 **Step 2:** The latest stable version of torchtune is hosted on PyPI and can be downloaded with the following command:
 
diff --git a/pyproject.toml b/pyproject.toml
index e79f999ccc..8f28ed9f60 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -10,8 +10,6 @@ authors = [
 ]
 keywords = ["pytorch", "finetuning", "llm"]
 dependencies = [
-    # multimodality
-    "torchvision",
 
     # Hugging Face integrations
     "datasets",
diff --git a/torchtune/modules/low_precision/_utils.py b/torchtune/modules/low_precision/_utils.py
index ee4cce0cbd..25db7eaafe 100644
--- a/torchtune/modules/low_precision/_utils.py
+++ b/torchtune/modules/low_precision/_utils.py
@@ -5,6 +5,9 @@
 # LICENSE file in the root directory of this source tree.
 
 from importlib.metadata import PackageNotFoundError, version
+from typing import Optional, Tuple
+
+import torch
 
 import torchao
 
@@ -13,7 +16,7 @@ def _is_fbcode():
     return not hasattr(torch.version, "git_version")
 
 
-def _get_torchao_version() -> Tuple[Optional[str], Optional[str]]:
+def _get_torchao_version() -> Tuple[Optional[str], Optional[bool]]:
     """
     Get torchao version. Returns a tuple of two elements, the first element
     is the version string, the second element is whether it's a nightly version.
@@ -21,25 +24,30 @@ def _get_torchao_version() -> Tuple[Optional[str], Optional[str]]:
 
     Checks:
         1) is_fbcode, then
-        2) torchao.__version__ (only defined for torchao >= 0.3.0), then
-        3) importlib's version(torchao) for non-nightly, then
-        4) importlib's version(torchao-nightly) for nightlies
+        2) importlib's version(torchao-nightly) for nightlies, then
+        3) torchao.__version__ (only defined for torchao >= 0.3.0), then
+        4) importlib's version(torchao) for non-nightly
+
 
     If none of these work, raise an error.
 
     """
     if _is_fbcode():
         return None, None
+    # Check for nightly install first
     try:
-        ao_version = torchao.__version__
-        is_nightly = False
-    except AttributeError:
-        ao_version = version("torchao")
-        is_nightly = False
-    # For importlib metadata, need to check nightly separately
-    except PackageNotFoundError:
         ao_version = version("torchao-nightly")
         is_nightly = True
-    except Exception as e:
-        raise PackageNotFoundError("Could not find torchao version") from e
+    except PackageNotFoundError:
+        try:
+            ao_version = torchao.__version__
+            is_nightly = False
+        except AttributeError:
+            ao_version = "unknown"
+    if ao_version == "unknown":
+        try:
+            ao_version = version("torchao")
+            is_nightly = False
+        except Exception as e:
+            raise PackageNotFoundError("Could not find torchao version") from e
     return ao_version, is_nightly
diff --git a/torchtune/utils/quantization.py b/torchtune/utils/quantization.py
index 619933ac6b..8117cf9f5e 100644
--- a/torchtune/utils/quantization.py
+++ b/torchtune/utils/quantization.py
@@ -10,10 +10,18 @@
 from torchao.quantization.quant_api import (
     Int4WeightOnlyGPTQQuantizer,
     Int4WeightOnlyQuantizer,
-    quantize,
     Quantizer,
 )
 
+from torchtune.modules.low_precision._utils import _get_torchao_version
+
+ao_version, is_nightly = _get_torchao_version()
+print(ao_version, is_nightly)
+if is_nightly and (ao_version >= "2024.7.3"):
+    from torchao.quantization.quant_api import quantize_ as quantize
+else:
+    from torchao.quantization.quant_api import quantize
+
 # importing TORCH_VERSION_AFTER_2_3 because `Int8DynActInt4WeightQuantizer`
 # is only available after 2.3 so we have to guard the pytorch versions to decide
 # the list of supported quantizers

From f45bfbdba7a08fcbdfbd22de7244f1d87bc33ddd Mon Sep 17 00:00:00 2001
From: Evan Smothers <ebs@fb.com>
Date: Mon, 8 Jul 2024 21:46:27 -0700
Subject: [PATCH 04/10] yaml fixes

---
 .github/workflows/gpu_test.yaml            | 4 ++--
 .github/workflows/recipe_test_nightly.yaml | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/gpu_test.yaml b/.github/workflows/gpu_test.yaml
index ce76ea03ec..ac66d23332 100644
--- a/.github/workflows/gpu_test.yaml
+++ b/.github/workflows/gpu_test.yaml
@@ -39,10 +39,10 @@ jobs:
         run: python -m pip install --upgrade pip
       - name: Install torch nightly
         if: ${{ matrix.torch-version == 'nightly' }}
-        run: python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu118
+        run: python -m pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu118
       - name: Install torch stable
         if: ${{ matrix.torch-version == 'stable' }}
-        run: python -m pip install torch
+        run: python -m pip install torch torchvision
       - name: Install remaining dependencies
         run: |
           python -m pip install -e ".[dev]"
diff --git a/.github/workflows/recipe_test_nightly.yaml b/.github/workflows/recipe_test_nightly.yaml
index a9e33da110..e3cfec69e7 100644
--- a/.github/workflows/recipe_test_nightly.yaml
+++ b/.github/workflows/recipe_test_nightly.yaml
@@ -49,7 +49,7 @@ jobs:
           python -m pip install lm-eval==0.4.*
       - name: Install torchao nightly
         if: ${{ matrix.torch-version == 'nightly' }}
-        pip install --pre torchao-nightly --index-url https://download.pytorch.org/whl/nightly/cu121
+        run: pip install --pre torchao-nightly --index-url https://download.pytorch.org/whl/nightly/cu121
       - name: Run recipe tests with coverage
         run: pytest tests -m integration_test --cov=. --cov-report=xml --durations=20 -vv
       - name: Upload Coverage to Codecov

From 574692439fefb89ed86276869185fa35ffe4addd Mon Sep 17 00:00:00 2001
From: Evan Smothers <ebs@fb.com>
Date: Mon, 8 Jul 2024 22:01:37 -0700
Subject: [PATCH 05/10] add pytest skip for nightly DTensor API

---
 tests/torchtune/utils/test_distributed.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/torchtune/utils/test_distributed.py b/tests/torchtune/utils/test_distributed.py
index 7b6754704d..38c82f8ed7 100644
--- a/tests/torchtune/utils/test_distributed.py
+++ b/tests/torchtune/utils/test_distributed.py
@@ -262,6 +262,10 @@ def world_size(self) -> int:
         return 2
 
     @gpu_test(gpu_count=2)
+    @pytest.mark.skipif(
+        version.parse(torch.__version__).base_version < "2.4.0",
+        reason="torch >= 2.4 required",
+    )
     def test_lora_state_dict(self):
         rank = self.rank
         is_rank_zero = rank == 0

From 9d0e193990e1567a718e5a7fb25acf1088c9eb6b Mon Sep 17 00:00:00 2001
From: Evan Smothers <ebs@fb.com>
Date: Mon, 8 Jul 2024 22:21:33 -0700
Subject: [PATCH 06/10] add back python 3.8

---
 .github/workflows/gpu_test.yaml              |  2 +-
 .github/workflows/recipe_test.yaml           |  2 +-
 .github/workflows/recipe_test_multi_gpu.yaml | 53 ++++++++++++++++++++
 .github/workflows/recipe_test_nightly.yaml   |  2 +-
 .github/workflows/unit_test.yaml             |  2 +-
 pyproject.toml                               |  2 +-
 6 files changed, 58 insertions(+), 5 deletions(-)
 create mode 100644 .github/workflows/recipe_test_multi_gpu.yaml

diff --git a/.github/workflows/gpu_test.yaml b/.github/workflows/gpu_test.yaml
index ac66d23332..c7f1840a5f 100644
--- a/.github/workflows/gpu_test.yaml
+++ b/.github/workflows/gpu_test.yaml
@@ -23,7 +23,7 @@ jobs:
     runs-on: linux.8xlarge.nvidia.gpu
     strategy:
       matrix:
-        python-version: ['3.9', '3.10', '3.11']
+        python-version: ['3.8', '3.9', '3.10', '3.11']
         torch-version: ["stable"]
     steps:
       - name: Check out repo
diff --git a/.github/workflows/recipe_test.yaml b/.github/workflows/recipe_test.yaml
index 852f34beaf..59b693a055 100644
--- a/.github/workflows/recipe_test.yaml
+++ b/.github/workflows/recipe_test.yaml
@@ -24,7 +24,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ['3.9', '3.10', '3.11']
+        python-version: ['3.8', '3.9', '3.10', '3.11']
     steps:
       - name: Check out repo
         uses: actions/checkout@v3
diff --git a/.github/workflows/recipe_test_multi_gpu.yaml b/.github/workflows/recipe_test_multi_gpu.yaml
new file mode 100644
index 0000000000..d62bcc81bc
--- /dev/null
+++ b/.github/workflows/recipe_test_multi_gpu.yaml
@@ -0,0 +1,53 @@
+name: Multi-GPU Recipe Tests
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+  workflow_dispatch:
+
+concurrency:
+  group: recipe-test-multi-gpu-${{ github.workflow }}-${{ github.ref == 'refs/heads/main' && github.run_number || github.ref }}
+  cancel-in-progress: true
+
+permissions:
+  id-token: write
+  contents: read
+
+defaults:
+  run:
+    shell: bash -l -eo pipefail {0}
+
+jobs:
+  recipe_test_multi_gpu:
+    runs-on: linux.8xlarge.nvidia.gpu
+    strategy:
+      matrix:
+        python-version: ['3.8', '3.9', '3.10', '3.11']
+        torch-version: ["stable"]
+    steps:
+      - name: Check out repo
+        uses: actions/checkout@v3
+      - name: Setup conda env
+        uses: conda-incubator/setup-miniconda@v2
+        with:
+          auto-update-conda: true
+          miniconda-version: "latest"
+          activate-environment: test
+          python-version: ${{ matrix.python-version }}
+      - name: Update pip
+        run: python -m pip install --upgrade pip
+      - name: Install torch nightly
+        if: ${{ matrix.torch-version == 'nightly' }}
+        run: python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu118
+      - name: Install torch stable
+        if: ${{ matrix.torch-version == 'stable' }}
+        run: python -m pip install torch
+      - name: Install remaining dependencies
+        run: |
+          python -m pip install -e ".[dev]"
+          python -m pip install lm-eval==0.4.*
+      - name: Run recipe tests with coverage
+        run: pytest tests -m integration_test --cov=. --cov-report=xml --durations=20 -vv
+      - name: Upload Coverage to Codecov
+        uses: codecov/codecov-action@v3
diff --git a/.github/workflows/recipe_test_nightly.yaml b/.github/workflows/recipe_test_nightly.yaml
index e3cfec69e7..cda5fef33f 100644
--- a/.github/workflows/recipe_test_nightly.yaml
+++ b/.github/workflows/recipe_test_nightly.yaml
@@ -23,7 +23,7 @@ jobs:
     runs-on: linux.8xlarge.nvidia.gpu
     strategy:
       matrix:
-        python-version: ['3.9', '3.10', '3.11']
+        python-version: ['3.8', '3.9', '3.10', '3.11']
         torch-version: ["stable", "nightly"]
     steps:
       - name: Check out repo
diff --git a/.github/workflows/unit_test.yaml b/.github/workflows/unit_test.yaml
index 706bf37860..3fd3c5bfbc 100644
--- a/.github/workflows/unit_test.yaml
+++ b/.github/workflows/unit_test.yaml
@@ -18,7 +18,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ['3.9', '3.10', '3.11']
+        python-version: ['3.8', '3.9', '3.10', '3.11']
     steps:
       - name: Check out repo
         uses: actions/checkout@v3
diff --git a/pyproject.toml b/pyproject.toml
index 8f28ed9f60..f42d39c7af 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -3,7 +3,7 @@
 name = "torchtune"
 description = "A native-PyTorch library for LLM fine-tuning"
 readme = "README.md"
-requires-python = ">=3.9"
+requires-python = ">=3.8"
 license = {file = "LICENSE"}
 authors = [
     { name = "PyTorch Team", email = "packages@pytorch.org" },

From 189c409ec5bec0ee8408dbfeec064bee5397dc6d Mon Sep 17 00:00:00 2001
From: Evan Smothers <ebs@fb.com>
Date: Mon, 8 Jul 2024 22:23:17 -0700
Subject: [PATCH 07/10] remove extra file

---
 .github/workflows/recipe_test_multi_gpu.yaml | 53 --------------------
 1 file changed, 53 deletions(-)
 delete mode 100644 .github/workflows/recipe_test_multi_gpu.yaml

diff --git a/.github/workflows/recipe_test_multi_gpu.yaml b/.github/workflows/recipe_test_multi_gpu.yaml
deleted file mode 100644
index d62bcc81bc..0000000000
--- a/.github/workflows/recipe_test_multi_gpu.yaml
+++ /dev/null
@@ -1,53 +0,0 @@
-name: Multi-GPU Recipe Tests
-
-on:
-  push:
-    branches: [ main ]
-  pull_request:
-  workflow_dispatch:
-
-concurrency:
-  group: recipe-test-multi-gpu-${{ github.workflow }}-${{ github.ref == 'refs/heads/main' && github.run_number || github.ref }}
-  cancel-in-progress: true
-
-permissions:
-  id-token: write
-  contents: read
-
-defaults:
-  run:
-    shell: bash -l -eo pipefail {0}
-
-jobs:
-  recipe_test_multi_gpu:
-    runs-on: linux.8xlarge.nvidia.gpu
-    strategy:
-      matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11']
-        torch-version: ["stable"]
-    steps:
-      - name: Check out repo
-        uses: actions/checkout@v3
-      - name: Setup conda env
-        uses: conda-incubator/setup-miniconda@v2
-        with:
-          auto-update-conda: true
-          miniconda-version: "latest"
-          activate-environment: test
-          python-version: ${{ matrix.python-version }}
-      - name: Update pip
-        run: python -m pip install --upgrade pip
-      - name: Install torch nightly
-        if: ${{ matrix.torch-version == 'nightly' }}
-        run: python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu118
-      - name: Install torch stable
-        if: ${{ matrix.torch-version == 'stable' }}
-        run: python -m pip install torch
-      - name: Install remaining dependencies
-        run: |
-          python -m pip install -e ".[dev]"
-          python -m pip install lm-eval==0.4.*
-      - name: Run recipe tests with coverage
-        run: pytest tests -m integration_test --cov=. --cov-report=xml --durations=20 -vv
-      - name: Upload Coverage to Codecov
-        uses: codecov/codecov-action@v3

From 31c02ca2acee3d024f2017da9c033c49b24f1568 Mon Sep 17 00:00:00 2001
From: Evan Smothers <ebs@fb.com>
Date: Mon, 8 Jul 2024 22:28:38 -0700
Subject: [PATCH 08/10] add torchvision to doc build job

---
 .github/workflows/build_docs.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/build_docs.yaml b/.github/workflows/build_docs.yaml
index 1f690a7617..3eaed1147a 100644
--- a/.github/workflows/build_docs.yaml
+++ b/.github/workflows/build_docs.yaml
@@ -39,7 +39,7 @@ jobs:
         run: python -m pip install --upgrade pip
       - name: Install dependencies
         run: |
-          python -m pip install torch
+          python -m pip install torch torchvision
           python -m pip install -e .
           cd docs
           python -m pip install -r requirements.txt
@@ -108,21 +108,21 @@ jobs:
         run: |
           git remote set-url origin https://pytorchbot:${GITHUB_PYTORCHBOT_TOKEN}@github.com/pytorch/torchtune.git
           set -euo pipefail
-          
-          # Convert refs/tags/v1.12.0rc3 into 1.12. 
+
+          # Convert refs/tags/v1.12.0rc3 into 1.12.
           # Adopted from https://github.com/pytorch/pytorch/blob/main/.github/workflows/_docs.yml#L150C11-L155C13
-          GITHUB_REF=${{ github.ref }} 
+          GITHUB_REF=${{ github.ref }}
           if [[ "${GITHUB_REF}" =~ ^refs/tags/v([0-9]+\.[0-9]+)\.* ]]; then
             TARGET_FOLDER="${BASH_REMATCH[1]}"
           else
             TARGET_FOLDER="main"
           fi
- 
+
           echo "Target Folder: ${TARGET_FOLDER}"
           mkdir -p "${TARGET_FOLDER}"
           rm -rf "${TARGET_FOLDER}"/*
           mv docs/* "${TARGET_FOLDER}"
-          
+
           git config user.name 'pytorchbot'
           git config user.email 'soumith+bot@pytorch.org'
           git add "${TARGET_FOLDER}" || true

From a0c9789de4a6eb21e86b531127c4b01138b93a3e Mon Sep 17 00:00:00 2001
From: Evan Smothers <ebs@fb.com>
Date: Tue, 9 Jul 2024 10:00:23 -0700
Subject: [PATCH 09/10] remove print statement

---
 torchtune/utils/quantization.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/torchtune/utils/quantization.py b/torchtune/utils/quantization.py
index 8117cf9f5e..44537da896 100644
--- a/torchtune/utils/quantization.py
+++ b/torchtune/utils/quantization.py
@@ -16,7 +16,6 @@
 from torchtune.modules.low_precision._utils import _get_torchao_version
 
 ao_version, is_nightly = _get_torchao_version()
-print(ao_version, is_nightly)
 if is_nightly and (ao_version >= "2024.7.3"):
     from torchao.quantization.quant_api import quantize_ as quantize
 else:

From 9b94fa1e144d3ac8bbdbb32b1495a600ff23cbca Mon Sep 17 00:00:00 2001
From: Evan Smothers <ebs@fb.com>
Date: Tue, 9 Jul 2024 11:46:27 -0700
Subject: [PATCH 10/10] address comments on readme

---
 README.md | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/README.md b/README.md
index 240bcd061a..9005b4e12a 100644
--- a/README.md
+++ b/README.md
@@ -156,15 +156,14 @@ You can find a full list of all our Llama3 configs [here.](recipes/configs/llama
 
 ## Installation
 
-**Step 1:** [Install PyTorch](https://pytorch.org/get-started/locally/). torchtune is tested with the latest stable PyTorch release as well as the preview nightly version. For multimodality
-be sure to also install torchvision.
+**Step 1:** [Install PyTorch](https://pytorch.org/get-started/locally/). torchtune is tested with the latest stable PyTorch release as well as the preview nightly version. For fine-tuning the multimodal LLMs available in the repo, you'll need to install torchvision as well.
 
 ```
 # Install stable version of PyTorch using pip
-pip3 install torch torchvision
+pip install torch torchvision
 
 # Nightly install for latest features
-pip3 install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu121
+pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu121
 ```
 
 **Step 2:** The latest stable version of torchtune is hosted on PyPI and can be downloaded with the following command: