Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] DoRA is broken #1903

Open
ebsmothers opened this issue Oct 25, 2024 · 0 comments
Open

[bug] DoRA is broken #1903

ebsmothers opened this issue Oct 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ebsmothers
Copy link
Contributor

Two separate DoRA bugs I just noticed:

(1) Llama 3.2 1B config with DoRA errors on state dict load. Repro:

tune run lora_finetune_single_device --config llama3_2/1B_lora_single_device \
gradient_accumulation_steps=1 max_steps_per_epoch=5 model.use_dora=True
...
Exception: Error converting the state dict. Found unexpected key: "layers.0.attn.q_proj.magnitude". Please make sure you're loading a checkpoint with the right format.

(2) Llama 3.2 Vision 11B model with DoRA has NaN loss. Repro:

tune run lora_finetune_single_device --config llama3_2_vision/11B_lora_single_device \
max_steps_per_epoch=5 gradient_accumulation_steps=1 model.use_dora=True

Once we fix them we should add recipe test cases setting model.use_dora=True to catch these errors in the future, cc @felipemello1.

@ebsmothers ebsmothers added the bug Something isn't working label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant