Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Delete FSDP1 code #1897

Open
8 tasks
ebsmothers opened this issue Oct 24, 2024 · 0 comments
Open
8 tasks

[Cleanup] Delete FSDP1 code #1897

ebsmothers opened this issue Oct 24, 2024 · 0 comments
Labels
community help wanted We would love the community's help completing this issue

Comments

@ebsmothers
Copy link
Contributor

A number of our APIs are holdovers from FSDP1 and can be deleted. A (probably non-exhaustive) list:

Apart from the last one, the only usage of all these APIs should be in unit tests. When deleting the test cases, we should also make sure that we have corresponding test cases for any analogous FSDP2 APIs.

@ebsmothers ebsmothers added the community help wanted We would love the community's help completing this issue label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community help wanted We would love the community's help completing this issue
Projects
None yet
Development

No branches or pull requests

1 participant