Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ChatFormat, InstructTemplate, old message converters #1895

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RdoubleA
Copy link
Contributor

@RdoubleA RdoubleA commented Oct 24, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Closes #1839. Closes #1849.

Changelog

What are the changes made in this PR?

  • Delete ChatFormat, InstructTemplate, and all references
  • Delete torchtune/data/_converters.py. These are replaced by the transforms in _messages.py
  • Delete the old dataset tutorial. All topics have already been covered in Basics section of documentation, and the tutorial refers to outdated APIs. Only sample packing was still new, so I moved that to its own section under Basics.
  • Update generate recipe to assume single prompt string and no chat format or instruct template since the prompt template is now defined on the tokenizer.

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented Oct 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1895

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2a69d76 with merge base dc0591c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2024
@@ -0,0 +1,52 @@
.. _packing_usage_label:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you snuck this in here you sneaky lil man

i love it

chat_format = _get_component_from_path(chat_format)
messages = chat_format.format(messages)
return self._tokenizer.tokenize_messages(messages)[0]
messages = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noobq: Is this identical to free-form generation when a prompt template isn't provided?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete chat_formats.py and instruct_formats.py Remove deprecated _converters.py file
3 participants