Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete chat_formats.py and instruct_formats.py #1849

Open
joecummings opened this issue Oct 16, 2024 · 0 comments · May be fixed by #1895
Open

Delete chat_formats.py and instruct_formats.py #1849

joecummings opened this issue Oct 16, 2024 · 0 comments · May be fixed by #1895
Assignees
@RdoubleA
Labels
better engineering Tasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs

Comments

@joecummings
Copy link
Contributor

These files are deprecated in favor of transform.
@joecummings joecummings added the better engineering Tasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs label Oct 16, 2024
@joecummings joecummings mentioned this issue Oct 16, 2024
Open
33 tasks
@RdoubleA RdoubleA linked a pull request Oct 24, 2024 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RdoubleA RdoubleA

Labels
better engineering Tasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ChatFormat, InstructTemplate, old message converters RdoubleA/torchtune
2 participants
@joecummings @RdoubleA