Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexing a 4D FrameBatch: Should this return a Frame or a 3D FrameBatch? #288

Open
NicolasHug opened this issue Oct 24, 2024 · 0 comments · May be fixed by #296
Open

Indexing a 4D FrameBatch: Should this return a Frame or a 3D FrameBatch? #288

NicolasHug opened this issue Oct 24, 2024 · 0 comments · May be fixed by #296

Comments

@NicolasHug
Copy link
Member

Opening this issue so we don't forget to discuss this: #283 (comment)

For now, indexing a 4D FrameBatch returns a (3D) Frame. We could instead return a 3D FrameBatch.

I suggest we first land #284, then I'll submit a PR that makes the change of returning a 3D FrameBatch instead - it'll be easier to evaluate the UX changes that this involves.

CC @ahmadsharif1
@NicolasHug NicolasHug linked a pull request Oct 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Indexing 4D FrameBatch now returns FrameBatch NicolasHug/torchcodec
1 participant
@NicolasHug