Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ code should not throw its own exceptions #212

Open
scotts opened this issue Sep 17, 2024 · 0 comments
Open

C++ code should not throw its own exceptions #212

scotts opened this issue Sep 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@scotts
Copy link
Contributor

scotts commented Sep 17, 2024

🐛 Describe the bug

Currently, the C++ VideoDecoder code will throw normal C++ exceptions such as throw std::runtime_exception(). This has caused some problems with how PyTorch handles custom C++ ops, resulting in segfaults. We should exclusively use PyTorch macros (TORCH_CHECK(), C10_THROW_ERROR(), etc) to make sure our C++ error handling correctly propagates to Python.

Versions

All versions.

@scotts scotts added the bug Something isn't working label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant