Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using libnpp, we should make sure we don't deallocate the memory while the kernel is still running #191

Open
ahmadsharif1 opened this issue Aug 20, 2024 · 0 comments
Open

When using libnpp, we should make sure we don't deallocate the memory while the kernel is still running #191

ahmadsharif1 opened this issue Aug 20, 2024 · 0 comments

Comments

@ahmadsharif1
Copy link
Contributor

We are using libnpp for color conversion here:

torchcodec/src/torchcodec/decoders/_core/VideoDecoder.cpp

Line 170 in f4065f1

status = nppiNV12ToRGB_8u_P2C3R(

libnpp uses its own CUDA stream, which is different from the pytorch CUDA streams.

We should add some synchronization code after this call so that Pyro users don't accidentally deallocate the tensor while the kernel is still running.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahmadsharif1