Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align C++ names with Python names #125

Open
NicolasHug opened this issue Jul 30, 2024 · 0 comments
Open

Align C++ names with Python names #125

NicolasHug opened this issue Jul 30, 2024 · 0 comments

Comments

@NicolasHug
Copy link
Member

Some of the names we use in C++ are slightly different from the ones we expose in Python. Currently the main ones are visible from the metadata:

num_frames_from_header=stream_dict.get("numFrames"),
num_frames_from_content=stream_dict.get("numFramesFromScan"),
begin_stream_from_content_seconds=stream_dict.get(
"minPtsSecondsFromScan"
),
end_stream_from_content_seconds=stream_dict.get(
"maxPtsSecondsFromScan"
),

We should align the C++ names with the Python ones.

facebook-github-bot pushed a commit that referenced this issue Jul 30, 2024
Summary:
Opened #125

Pull Request resolved: #126

Reviewed By: scotts

Differential Revision: D60449281

Pulled By: NicolasHug

fbshipit-source-id: ed73b85750bfff99c3fc905abb62e3638dc08452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant