We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If users create a column from a Python list, we actually dispatch that directly to C++. For example,
vals = [1, 2, 3, 4, 5] col = ta.Column(vals, device="cpu")
We dispatch that directly to C++ through pybind11: https://github.com/facebookresearch/torcharrow/blob/d680bfdc0f6a6bb6c3a29c2a67d62006782d6558/csrc/velox/lib.cpp#L135-L141 However, if a user creates a column from a numpy array, we currently have to handle that (slowly) in Python. For example,
vals = [1, 2, 3, 4, 5] arr = numpy.array(vals) col = ta.Colmun(arr, device="cpu")
That will be handled only on the Python side: https://github.com/facebookresearch/torcharrow/blob/d680bfdc0f6a6bb6c3a29c2a67d62006782d6558/torcharrow/scope.py#L226-L233 We should be able to handle numpy arrays natively in C++; pybind11 already exposes a numpy array type.
The text was updated successfully, but these errors were encountered:
Here is the original from_numpy API prototype: https://github.com/facebookresearch/torcharrow/blob/95daa1fabd5a3098be112d487e085e13f5447786/torcharrow/_interop.py#L88-L100
from_numpy
But i don't think we have supported natively in CPU backend (only in the "demo" backend where data is stored as numpy array -- removed in #33)
Some API reference:
to_numpy
Sorry, something went wrong.
gpu kernel for 1d sparse recat gen (pytorch#179)
860d574
Summary: Pull Request resolved: pytorch/torchrec#179 * add the `expand_into_jagged_permute` GPU kernel callsite for generating 1D sparse data permute Reviewed By: youyou6093 Differential Revision: D34778094 fbshipit-source-id: d14174cea809f3e33b1d860d297c7d318a930e34
No branches or pull requests
If users create a column from a Python list, we actually dispatch that directly to C++. For example,
We dispatch that directly to C++ through pybind11:
https://github.com/facebookresearch/torcharrow/blob/d680bfdc0f6a6bb6c3a29c2a67d62006782d6558/csrc/velox/lib.cpp#L135-L141
However, if a user creates a column from a numpy array, we currently have to handle that (slowly) in Python. For example,
That will be handled only on the Python side:
https://github.com/facebookresearch/torcharrow/blob/d680bfdc0f6a6bb6c3a29c2a67d62006782d6558/torcharrow/scope.py#L226-L233
We should be able to handle numpy arrays natively in C++; pybind11 already exposes a numpy array type.
The text was updated successfully, but these errors were encountered: