-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Python 3.12 compatibility #818
Conversation
Unfortunately,
But if I try running it in an environment that has Python 3.11, it passes. To reproduce the failure:
|
I was able to fix that error by updating the |
e33b639
to
2490a0f
Compare
@@ -71,7 +83,7 @@ jobs: | |||
- name: Build wheel | |||
shell: bash | |||
run: | | |||
python3 -mpip install wheel | |||
python3 -mpip install wheel setuptools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this to fix this failure: https://github.com/pytorch/tensordict/actions/runs/9555748210/job/26354755267?pr=818
In Python 3.12, setuptools is required to be able to import distutils
Not sure if this is really the best place to add this dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok, long term we should use smth like what torchtune has (ie no setup.py at all)
https://github.com/pytorch/torchtune/blob/main/pyproject.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for this!
Description
Adds support for Python 3.12
Motivation and Context
fixes #766
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!