Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Remove forkingpickler #1049

Merged
merged 2 commits into from
Oct 21, 2024
Merged

[BugFix] Remove forkingpickler #1049

merged 2 commits into from
Oct 21, 2024

Conversation

bhack
Copy link
Contributor

@bhack bhack commented Oct 19, 2024

Description

fixes: #1048

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • [X ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • [X ] I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 19, 2024
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens changed the title Remove forkingpickler [BugFix] Remove forkingpickler Oct 21, 2024
@vmoens vmoens added bug Something isn't working versioning labels Oct 21, 2024
@vmoens vmoens merged commit 1659518 into pytorch:main Oct 21, 2024
49 of 53 checks passed
@bhack
Copy link
Contributor Author

bhack commented Oct 21, 2024

Do you plan to make a release compatible with pytorch 2.5.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pytorch==2.5.0 breaks tensordict
3 participants