-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Add min / max reduction #1012
Comments
on it! |
I'm working on this and I have a question for you:
|
If it were up to me, I would prefer |
Cool I tried to do that. LMK if these changes make sense |
Is amin() here min().values? In torch, those two behave differently in the backward pass afaik |
Oh good point, I should use amin directly then |
Motivation
For supporting einops, tensordict would need a min/max reduction.
Solution
Similiar to mean, etc. the min and max should be implemented in https://github.com/pytorch/tensordict/blob/main/tensordict/base.py by calling
_cast_reduction
I did not find any issue or explaination why this is missing..
The text was updated successfully, but these errors were encountered: