Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nose-tap not reporting skipped tests #21

Open
atodorov opened this issue Jan 26, 2019 · 1 comment
Open

nose-tap not reporting skipped tests #21

atodorov opened this issue Jan 26, 2019 · 1 comment

Comments

@atodorov
Copy link
Contributor

I have the following:

class GivenConfigurationFileExists(unittest.TestCase):
    @unittest.skip('should be implemented in tcms-api')
    def test_when_plugin_initializes_then_uses_config(self):
        self.fail('not implemented')

while nose is able to discover and execute this (reporting 1 skipped test) nose-tap doesn't snow anything in the output. I was expecting to have an ok 1 <name> # SKIP: the message from decorator

See:
kiwitcms/tap-plugin@1d26e94

and:

https://travis-ci.org/kiwitcms/tap-plugin/builds/484696806

@mblayman
Copy link
Member

@atodorov, thanks for the report!

Taking a quick look at the code, it might be related to addFailure in the plugin not calling add_skip on the tracker. I think when I wrote this that I thought skips would only come through the addError path. Perhaps it's missing a case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants