-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove geom_col
argument in element_as_gdf()
?
#722
Labels
Comments
Can you think of a use case when you want the column to be called differently and it couldn't be done via an intermediate |
Nope, I can't think of anything. Let's nix it. |
This was referenced May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#720 introduced a small
ruff
regression where thegeom_col
keyword is no longer used inutil._arcs_as_gdf()
, which triggers aruff
failure in pre-commit.The thought here is that maybe we should remove the
geom_col
argument inelement_as_gdf()
? And always default to"geometry"
.EDIT
v1.8.0
The text was updated successfully, but these errors were encountered: