You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometimes, when reviewing a PR, the left diff is empty when it should not be.
I use local fs so right dif always comes from disk directly, but I suppose this could also happen for right diff.
This does not happen everytime, so I suspect some sort of race condition to be the root cause.
Describe what you expected to happen
The left diff buffer should show the content of the file at the base commit
How to reproduce it (as minimally and precisely as possible)
(Not sure if mandatory) Use local fs
Resume a PR review
Sometimes, one of the files will be empty when it should not, not all the time, not always the same file, does not seem scoped to a single PR.
Tell us your environment
Nixos, nvim from unstable
NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1713773202
Run "nvim -V1 -v" for more info
Anything else we need to know?
I dug a bit on this. I could not go further yet since I am quite unfamiliar with plenary and I could not find documentation. utils.get_file_at_commit sometimes returns an empty array despite commit being present locally.
When I print output and stderr here, both tables are empty.
I also printed error code and signal (the second and third arg of the on_exit cb), 0 for both which seem normal.
Somehow, the output of git show rev:file from Plenary remains empty, which I have no idea why.
I will update the issue if I find anything else, right now the only workaround I found was to close the review buffers/restart nvim and re open the PR.
The text was updated successfully, but these errors were encountered:
Issue Description
Type: bug report
Describe what happened (or what feature you want)
Sometimes, when reviewing a PR, the left diff is empty when it should not be.
I use local fs so right dif always comes from disk directly, but I suppose this could also happen for right diff.
This does not happen everytime, so I suspect some sort of race condition to be the root cause.
Describe what you expected to happen
The left diff buffer should show the content of the file at the base commit
How to reproduce it (as minimally and precisely as possible)
Tell us your environment
Nixos, nvim from unstable
Anything else we need to know?
I dug a bit on this. I could not go further yet since I am quite unfamiliar with plenary and I could not find documentation.
utils.get_file_at_commit
sometimes returns an empty array despite commit being present locally.When I print output and stderr here, both tables are empty.
I also printed error code and signal (the second and third arg of the
on_exit
cb),0
for both which seem normal.Somehow, the output of
git show rev:file
from Plenary remains empty, which I have no idea why.I will update the issue if I find anything else, right now the only workaround I found was to close the review buffers/restart nvim and re open the PR.
The text was updated successfully, but these errors were encountered: