Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove axios #4

Open
macabeus opened this issue Apr 4, 2020 · 1 comment
Open

Remove axios #4

macabeus opened this issue Apr 4, 2020 · 1 comment

Comments

@macabeus
Copy link

macabeus commented Apr 4, 2020 •
edited
Loading

I really think that is unnecessary to use axios on frontend, because we could use the built-in browser API fetch.
Axios will be just yet another dependency to manage and increase the bundle size.
@LorhanSohaky
Copy link
Member

I chose to use axios due to the ease of error handlers.
Handling Errors

I think that in the future we can exchange axios for fetch, but keeping in mind everything that still needs to be done, it is not a priority.

Project bundle size:2.1 mB
Axios bundle size:13.1 kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macabeus @LorhanSohaky