Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move JsonDecodeError type to separate package #83

Open
srghma opened this issue Jun 19, 2020 · 5 comments
Open

move JsonDecodeError type to separate package #83

srghma opened this issue Jun 19, 2020 · 5 comments
Labels
type: enhancement A new feature or addition.

Comments

@srghma
Copy link
Member

srghma commented Jun 19, 2020

this would allow composing https://github.com/garyb/purescript-codec-argonaut/ and this lib

e.g. the purescript-codec-argonaut JsonCodec where some part is derived using class machinery? would be cool

@garyb

@thomashoneyman
Copy link
Contributor

I think if both codec-argonaut and argonaut-codecs use the same error type that it makes sense to move the error type into argonaut-core. Both libraries already depend on it. Then it can be shared and yes functions from both libraries could be used (though I don’t know how common that would be).

@srghma
Copy link
Member Author

srghma commented Jun 19, 2020

hm, it would be easier, but I would move it to the separate package, so that users could choose between different error types

the core was working fine without JsonDecodeError 🤔

@thomashoneyman thomashoneyman added the type: enhancement A new feature or addition. label Aug 25, 2020
@stale stale bot added the status: wontfix The maintainers of this library don't think the issue is actually a problem. label Nov 23, 2020
@thomashoneyman thomashoneyman removed the status: wontfix The maintainers of this library don't think the issue is actually a problem. label Nov 23, 2020
@thomashoneyman
Copy link
Contributor

Sorry about that, removed the label.

@srghma
Copy link
Member Author

srghma commented Nov 23, 2020

hi, @thomashoneyman, so what do you think: move error type to the argonaut-core OR create separate package argonaut-error?

@purescript-contrib purescript-contrib deleted a comment from stale bot Nov 23, 2020
@garyb
Copy link
Member

garyb commented Nov 23, 2020

There's some discussion here about options for the error type: #85 since I think the current closed sum isn't exactly perfect, but I don't know the best way forwards yet to supporting more stuff without just allowing arbitrary strings. I'm probably not going to make my library dependent on an external error type until I figure out what to do about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A new feature or addition.
Development

No branches or pull requests

3 participants