Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favicon to site - Open Pull Request #14

Closed
shaunagm opened this issue Apr 29, 2021 · 5 comments · Fixed by #53 · May be fixed by #20
Closed

Add favicon to site - Open Pull Request #14

shaunagm opened this issue Apr 29, 2021 · 5 comments · Fixed by #53 · May be fixed by #20
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@shaunagm
Copy link
Contributor

Favicons are set in the head of the html file, which right now is in the template file full_width_base.html. I believe there's an existing favicon that's just the Python logo, in one of the other PSF repositories or on the website. So to do this task, please track down the icon (or make a cool new one), add it to the static_sources, and stick a reference to it via Django's template tags in full_width_base.html.
@shaunagm shaunagm added enhancement New feature or request good first issue Good for newcomers labels Apr 29, 2021
@martin-martin
Copy link

I'd like to tackle this during the upcoming PyCon sprint :)

@martin-martin martin-martin mentioned this issue May 15, 2021
Open
@martin-martin
Copy link

Could be fun to customize it a little, maybe add some glasses to one of the snakes, and some hair to the other one (similar to how the graphics are on the site) :)

LMK if this is wanted and I could give it a go, too 🎨 🤓

@meg-ray
Copy link
Contributor

meg-ray commented May 15, 2021

Could be fun to customize it a little, maybe add some glasses to one of the snakes, and some hair to the other one (similar to how the graphics are on the site) :)

LMK if this is wanted and I could give it a go, too

@martin-martin What a fun idea! If you haven't already, please feel free to go for it!

@meg-ray meg-ray changed the title Add favicon to site Add favicon to site - Open Pull Request May 16, 2021
@martin-martin
Copy link

@meg-ray added a design that takes glasses and hair from pythonineducation. 🐍

@anaypant
Copy link
Contributor

anaypant commented Jul 7, 2021

Hi Meg,
I just fixed this as my first issue on my fork @ https://github.com/anaypant/python-in-edu. Please allow me to make a pull request, so I can merge the new favicon. Let me know which favicon you want me to use. I am using

https://github.com/anaypant/python-in-edu/blob/master/python-in-edu/static_source/images/favicon.ico

right now. Thanks!
-Anay

@anaypant anaypant mentioned this issue Jul 7, 2021
Merged
@mpant mpant linked a pull request Jul 7, 2021 that will close this issue
Pull request for issue #14 : (Add favicon to site) #53
Merged
@mpant mpant closed this as completed in #53 Jul 7, 2021
mpant added a commit that referenced this issue Jul 7, 2021
@mpant
Merge pull request #53 from anaypant/master
abe0977 
Pull request for issue #14 : (Add favicon to site)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
4 participants
@shaunagm @meg-ray @martin-martin @anaypant