Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most of the calls to parseResponse in client have unchecked err values #5

Open
myrade opened this issue Mar 24, 2021 · 0 comments
Open

Comments

@myrade
Copy link
Contributor

myrade commented Mar 24, 2021

eg. https://github.com/provideservices/provide-go/blob/dev/api/client.go#L219

There are 14 instances in this file. Might need to add more logic as well - in the case that triggered it I timed out the handler with an enormous request so resp.StatusCode was invalid and caused a panic. We're attacking the request size elsewhere, but something that might need to be addressed here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant