Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Reducer.combine(Self...) instead of Reducer.combine([Self]) #115

Open
RemiBardon opened this issue Aug 19, 2022 · 0 comments
Open

Use Reducer.combine(Self...) instead of Reducer.combine([Self]) #115

RemiBardon opened this issue Aug 19, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@RemiBardon
Copy link
Member

For some reason, Xcode doesn't select the correct symbols when +clicking or +clicking on a Reducer which is inside .combine([]).
I preferred this syntax as it allows us to add a trailing comma, which improves git authoring and reviewing, but I found that using .combine(_ reducers: Self...) fixes the issue.

Here is an example:

Screen.Recording.2022-08-19.at.12.12.31.mov
@RemiBardon RemiBardon added the good first issue Good for newcomers label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant