Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multicore feature from msm bench #126

Closed
CPerezz opened this issue Jan 10, 2024 · 1 comment · Fixed by #127
Closed

Remove multicore feature from msm bench #126

CPerezz opened this issue Jan 10, 2024 · 1 comment · Fixed by #127

Comments

@CPerezz
Copy link
Member

CPerezz commented Jan 10, 2024 •
edited
Loading 

[[bench]]
name = "msm"
harness = false
required-features = ["multicore"]

Seems like we had a leftover feature for msm benchs

Originally posted by @kilic in #122 (comment)
@kilic kilic mentioned this issue Jan 10, 2024
Merged
@duguorong009
Copy link
Contributor

@CPerezz @kilic
Can we merge the PR #127?

Whenever I try the release build for testing, it does show the following warning.

warning: invalid feature `multicore` in required-features of target `msm`: `multicore` is not present in [features] section

I am sure the PR is ready for merge(got the approval).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove some leftovers kilic/halo2curves
2 participants
@CPerezz @duguorong009