Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHRise Crashes with OpenVR or OpenXR with SteamVR on the pd_upscaler branch #1134

Closed
oneup03 opened this issue Oct 15, 2024 · 8 comments
Closed

Comments

@oneup03
Copy link

oneup03 commented Oct 15, 2024

Describe the bug
REFramework crashes MHRise after initializing with either OpenVR or OpenXR on the pd_upscaler branch and using SteamVR

Upload logs and any crash dumps
Here are dumps from both OpenVR and OpenXR
OVR_re2_framework_log.txt
OVR_reframework_crash.dmp
OXR_re2_framework_log.txt
OXR_reframework_crash.dmp

Identify the REFramework version
1f6fca2

Desktop and VR:

  • Windows 11
  • RTX2080ti
  • i7-8086k

Virtual Reality:

  • VRto3D V2.0.0 (SteamVR)
  • OpenVR and OpenXR

Additional context
v1.5.7 release runs normally
9a65668 also runs normally

@praydog
Copy link
Owner

praydog commented Oct 20, 2024

MHRise's upscaler branch was never fixed as the game has DLSS already. Though I'm aware that it should probably be fixed as the new renderer in it (DLSS/FSR aside...) actually fixes various rendering issues in the game in VR (or in your case, VRto3D).

If I get some time I can probably fix it. It's usually just a few offsets that need to be adjusted in the renderer code.

@oneup03
Copy link
Author

oneup03 commented Oct 20, 2024

When you have time, that would be greatly appreciated!

I've been trying the different pd_upscaler builds to see if they worked with MHRise due to the rendering issues like #400

@praydog
Copy link
Owner

praydog commented Oct 21, 2024

I almost have it fixed in 7990c00.

However it crashes when any loading occurs in VR. The upscalers work though.

@praydog
Copy link
Owner

praydog commented Oct 21, 2024

d967aa7 has improved the crashing a bit, now I'm just dealing with issues where DoF seems to be active in the right eye and bloom appears to be blown out really bad.

@praydog
Copy link
Owner

praydog commented Oct 21, 2024

Fully fixed in 8b0d835

You can re-open if you notice any stability issues

@praydog praydog closed this as completed Oct 21, 2024
@oneup03
Copy link
Author

oneup03 commented Oct 22, 2024

Did some more testing with 8b0d835 in OpenXR/OpenVR and found a few things:

  • Ambient Occlusion isn't rendering right in VR (hard to see unless you use some kind of 3D photo viewer)
  • Desktop Screenshot 2024 10 21 - 18 33 21 03
  • The game crashed when I traveled to the Lava fields for the 3 star quest to hunt an Anjanath, but didn't generate a dump. This was in OpenXR mode and I couldn't reproduce it again
  • Screenshot 2024-10-21 183728
  • OXR_re2_framework_log.txt
  • It's not a new issue (existed with old renderer), but the detailed map view when you hold left bumper doesn't render correctly and the weapon tree UI at a blacksmith is missing UI elements
  • Desktop Screenshot 2024 10 21 - 19 07 13 86
  • Desktop Screenshot 2024 10 21 - 19 09 33 40
  • In OpenVR, the first loading screen colors are inverted, but this is minor

@oneup03
Copy link
Author

oneup03 commented Oct 24, 2024

Also, there are supposed to be monster status icons that show up in the upper right that don't work currently.
Here's what the blacksmith, detailed map view and the monster icons are supposed to look like:
Screenshot 2024-10-23 221543
Screenshot 2024-10-23 221942

@oneup03
Copy link
Author

oneup03 commented Oct 25, 2024

I tested some more and didn't experience a crash again. Also, it looks like the new renderer did fix the monster icons, so ignore that part of my previous post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants