Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display appropriate error message when file cannot be opened in duckdb-based data explorer #5133

Closed
wesm opened this issue Oct 23, 2024 · 2 comments
Closed

Display appropriate error message when file cannot be opened in duckdb-based data explorer #5133

wesm opened this issue Oct 23, 2024 · 2 comments
Assignees
@wesm
Labels
area: data explorer Issues related to Data Explorer category. enhancement New feature or request sharp-edge
Milestone
2024.11.0 Pre-Rel...

Comments

@wesm
Copy link
Contributor

wesm commented Oct 23, 2024 •
edited
Loading

Unlike in-memory data frames in Python or R, it may not be possible to open a corrupted .parquet or .csv file (or other supported file type) in DuckDB. In these cases, we can open a data explorer but display the error message generated by DuckDB, with a prompt to close the window like when the data explorer becomes disconnected for various reasons.

Presently it is not straightforward to route the error information into the "disconnected state" overlay for the data explorer, so will need some help determining the right approach.

If we don't address this, then when the user tries to open a corrupt file, a blank data explorer shows up which makes the application look broken.
@wesm wesm added enhancement New feature or request area: data explorer Issues related to Data Explorer category. sharp-edge labels Oct 23, 2024
@wesm wesm added this to the 2024.11.0 Pre-Release milestone Oct 23, 2024
@wesm wesm self-assigned this Oct 24, 2024
@wesm wesm mentioned this issue Oct 24, 2024
Merged
@wesm
Copy link
Contributor Author

wesm commented Oct 24, 2024

I put a broken file that you can use for QA/verification here:

https://github.com/posit-dev/qa-example-content/blob/main/data-files/100x100/100x100_broken.parquet

jmcphers pushed a commit that referenced this issue Oct 31, 2024
@wesm @softwarenerd
Data Explorer: Display duckdb error message when file fails to open (#…
e0d844b 
…5172)

Addresses #5133. This was a bit messy but the simplest way I saw to
bubble up the error information. I added optional parameters to
BackendState that allow an error message to be intercepted and
displayed.


![image](https://github.com/user-attachments/assets/9945add9-b469-4329-ae15-34f979620c54)

I need some CSS help to make the div a reasonable relative width and for
the text to wrap.

---------

Co-authored-by: Brian Lambert <brianlambert@gmail.com>
@jonvanausdeln
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2024.11.0-140
OS Version(s) : Windows 11, Ubuntu 24

Test scenario(s)

using https://github.com/posit-dev/qa-example-content/blob/main/data-files/100x100/100x100_broken.parquet

Link(s) to TestRail test cases run or created:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesm wesm

Labels
area: data explorer Issues related to Data Explorer category. enhancement New feature or request sharp-edge
Projects
None yet
Milestone
2024.11.0 Pre-Release
Development

No branches or pull requests
2 participants
@wesm @jonvanausdeln