Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux Manjaro install has file that conflicts with VS Code #4875

Closed
timtmok opened this issue Oct 2, 2024 · 1 comment
Closed

Linux Manjaro install has file that conflicts with VS Code #4875

timtmok opened this issue Oct 2, 2024 · 1 comment
Assignees
@juliasilge
Labels
area: builds Issues related to Builds category. bug Something isn't working os-linux Linux issue support
Milestone
2024.11.0 Pre-Rel...

Comments

@timtmok
Copy link
Contributor

timtmok commented Oct 2, 2024

System details:

Positron and OS details:

2024.09.103

Describe the issue:

This was originally reported in a discussion post. Installing Positron on Linux Manjaro when VS Code has already been installed fails due to a file conflict.

Extracting the DEB file downloaded from the Positron releases shows that it will try to install /usr/share/pixmaps/com.visualstudio.code.oss.png, which is actually the Positron logo.

I think the file name is coming from here:

positron/product.json

Line 33 in fd9bb6f

"linuxIconName": "com.visualstudio.code.oss",

Steps to reproduce the issue:

  1. Install VS Code using pamac build visual-studio-code-bin on Linux Manjaro (
  2. Install Positron using pamac build positron-ide-devel-bin

Workaround is to rename that file, which will allow the install to complete successfully.

For verification, extracting the DEB with ar x <Positron deb file> and the tar with tar -xvf data.tar.gz. Or viewing what would be installed with dpkg -c <Positron deb file.

Expected or desired behavior:

The install should be successful

Were there any error messages in the UI, Output panel, or Developer Tools console?

positron-ide-devel-bin: /usr/share/pixmaps/com.visualstudio.code.oss.png already exists
@timtmok timtmok added the bug Something isn't working label Oct 2, 2024
@juliasilge juliasilge added area: builds Issues related to Builds category. support os-linux Linux issue labels Oct 3, 2024
@juliasilge juliasilge added this to the 2024.11.0 Pre-Release milestone Oct 7, 2024
@juliasilge juliasilge self-assigned this Oct 23, 2024
@juliasilge juliasilge mentioned this issue Oct 23, 2024
Merged
juliasilge added a commit that referenced this issue Oct 28, 2024
@juliasilge
Use a Positron-specific name for Linux icon (#5134)
d85e8d8 
Addresses #4875 

This string is used in
https://github.com/posit-dev/positron/blob/91be0db898da1afca6873445b6c402806a77d881/build/gulpfile.vscode.linux.js
when the Linux build is created, and we need to have a filename that
doesn't conflict with VS Code.

### QA Notes

- Create a Linux release build
- `ar -x Positron-2099.12.0-999.deb`
- `tar -xvf data.tar.xz`
- Look at the filename located at `usr/share/pixmaps/`
@jonvanausdeln
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2024.11.0-140
OS Version(s) : Ubuntu 24

Test scenario(s)

Extracted .deb file and I see

co.posit.positron.png

as expected

Link(s) to TestRail test cases run or created:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliasilge juliasilge

Labels
area: builds Issues related to Builds category. bug Something isn't working os-linux Linux issue support
Projects
None yet
Milestone
2024.11.0 Pre-Release
Development

No branches or pull requests
3 participants
@jonvanausdeln @timtmok @juliasilge