Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling 'Hide user creation log entries in recent changes' in Special:Preferences has no impact #1

Open
RhinosF1 opened this issue Oct 17, 2019 · 3 comments

Comments

@RhinosF1
Copy link

If the 'Hide user creation log entries in recent changes' preference is disabled then User Creation Logs are still not show in Special:RecentChanges.

Mediawiki Version: 1.33.0
Extension version: 1.3 (7715930)
Site: test1.miraheze.org

@poke
Copy link
Owner

poke commented Oct 17, 2019

Hmm, I wonder if this might be caused by that new recent changes filter panel, or some backend changes that were part of this. The wiki where we are actively using this extension is still running on 1.30.0. So that might be the cause of that.

Disabling that fancy filter on your wiki unfortunately also doesn’t appear to change anything. But I cannot really make the user creation logs appear at all on your recent changes. Could you quickly confirm whether the logs do appear when you disable the extension altogether?

I’ll spin up a current test wiki tomorrow so I can check this out properly. – Thanks for reporting this!

@RhinosF1
Copy link
Author

Yes, the logs appear fine on wikis with the extension disabled.

@poke
Copy link
Owner

poke commented Oct 19, 2019

First of all, I am able to fully reproduce this problem on a current MediaWiki installation. I did some investigations now and as suspected, that new filter panel and its backend do conflict with this extension. The extension is using the ChangesListSpecialPageFilters hook which was removed in 1.32, so it is no wonder that the extension no longer works.

I’m working on migrating to the new hook now, so that the extension integrates into the new filter logic. That should be a quick fix that should make everything work again.

However, in the long run, I will probably have to change the extension a bit more to make the functionality fit more into the much more complex filter panel (which also allows for much more customization). I’ll have to play around with it a bit more to see what would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants