Unit tests

[dktapps]

The following things should be tested:

• Basic parity with appropriate pack() and unpack() codes with selected values
• Symmetry of encoding and decoding
• read*() must correctly handle non-reference types by throwing an error
• read*() must correctly update reference integer offset parameter if given
• read*() must correctly handle not being given an offset parameter
• read*() must read from the correct place when given an offset parameter
• writeUnsignedVarInt() must handle negative numbers properly (i.e. it must terminate)
• readUnsignedVarInt() must limit the number of bytes read and error appropriately
• read*() functions must error properly when not given enough bytes
• clone must work correctly on ByteBuffer
• serialize and unserialize must work correctly on ByteBuffer
• $buffer = new ByteBuffer($data) should behave the same as $buffer = new ByteBuffer(); $buffer->writeByteArray($data);

to be continued ...