Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for lazy creation #54

Open
tgross35 opened this issue Oct 17, 2023 · 1 comment
Open

Refactoring for lazy creation #54

tgross35 opened this issue Oct 17, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@tgross35
Copy link
Contributor

Some dictionaries are too big, e.g. Hungarian is >1GB RAM with our current setup.

To do the below, we will need to split our affix computations into create_word, our current format that makes the words in advance, and test_word that can see if an affix applies.

It would be best to control how lazy or eager we want this to be. For example:

  • Always lazy: use test_word for everything, no internal state
  • Dynamic: precompute nothing, cache results as we create words
  • Fully eager: precompute everything and store it (like we do now)
@tgross35 tgross35 added the enhancement New feature or request label Oct 17, 2023
@tgross35
Copy link
Contributor Author

Probably want to overlap this with #45 somehow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant