Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add help as a base option for tinymce plugins #41 #58

Closed

Conversation

rber474
Copy link
Member

@rber474 rber474 commented Feb 23, 2024

Updated from master and recreating changes

@rber474 rber474 linked an issue Feb 23, 2024 that may be closed by this pull request
@mister-roboto
Copy link

Rafael Bermudez Horcajada your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@mister-roboto
Copy link

@rber474 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@rber474
Copy link
Member Author

rber474 commented Feb 23, 2024

Hi @mauritsvanrees @ableeb , Plone Contributors Agreement verifier failed but I signed it months ago.

@mister-roboto
Copy link

Rafael Bermudez Horcajada your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@stevepiercy
Copy link
Contributor

@rber474 would you please check the email on you PCA against the email on your GitHub account. Do they match? It is also possible that the person transferring your email from your PCA into the system made a mistake. Can you contact agreements@plone.org to verify?

FWIW, your GitHub account is a member of @plone/developers team.

@rber474
Copy link
Member Author

rber474 commented Feb 23, 2024

Ohhh global config of email account in company laptop! Sorry guys!

@rber474
Copy link
Member Author

rber474 commented Feb 23, 2024

@jenkins-plone-org please run jobs

@rber474 rber474 closed this Feb 23, 2024
@rber474
Copy link
Member Author

rber474 commented Feb 23, 2024

Close to fix commits

@rber474 rber474 deleted the 41-add-help-as-a-base-option-for-tinymce-plugins branch February 23, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add help as a base option for TinyMCE plugins
3 participants