Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt styles to Plone 6 #96

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adapt styles to Plone 6 #96

wants to merge 5 commits into from

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Jul 26, 2021

Fix #95

@mister-roboto
Copy link

@pbauer thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@pbauer
Copy link
Member Author

pbauer commented Jul 26, 2021

@jenkins-plone-org please run jobs

@pbauer pbauer changed the title Adapt viewlet styles to Plone 6 Adapt styles to Plone 6 Jul 26, 2021
@pbauer
Copy link
Member Author

pbauer commented Aug 2, 2021

@jenkins-plone-org please run jobs

@jensens
Copy link
Member

jensens commented Aug 12, 2021

@jenkins-plone-org please run jobs

@@ -45,7 +45,7 @@
class=".diff.DiffView"
name="iterate_diff"
template="diff.pt"
permission="zope2.View"
permission="cmf.ModifyPortalContent"
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbauer I found this old PR while testing plone/Products.CMFPlone#1452. The style updates look good to me. The permission updates also look desirable but I think they will need a bit more work to ensure the rolemap is set up correctly; could you separate out that change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with #120
The rolemap is setup the old-school way in permissiosn.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt styles to Plone 6
4 participants