Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update modification date on canceled checkout #103

Open
ewohnlich opened this issue Aug 9, 2022 · 0 comments
Open

Don't update modification date on canceled checkout #103

ewohnlich opened this issue Aug 9, 2022 · 0 comments

Comments

@ewohnlich
Copy link

plone.app.iterate 4.0.3 (pinned by Plone 5.2.8)

A canceled checkout calls "baseline.reindexObject()" https://github.com/plone/plone.app.iterate/blob/4.0.3/plone/app/iterate/browser/cancel.py#L48 which results in the modification date being updated. I don't think this makes sense - to an end user literally nothing has changed. Unless reindexObject is somehow necessary to trigger relation cleanup, maybe we should pass a value for idxs to this method (reindexObject only updates modification date if idxs==[]). This might already be done by the event listener if I'm following correctly https://github.com/plone/plone.app.iterate/blob/4.0.3/plone/app/iterate/subscribers/locking.py#L56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant