Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL1 #493

Closed
vladdeSV opened this issue Mar 30, 2023 · 8 comments
Closed

WSL1 #493

vladdeSV opened this issue Mar 30, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@vladdeSV
Copy link

Re-installed my computer and was put back to WSL1. This caused some problems (#490, #491) which were solved by upgrading to WSL2. I believe WSL1 is the default version.

It seems tea does not play nice with WSL1.

@mxcl
Copy link
Member

mxcl commented Mar 30, 2023

Thanks for the investigation.

We will support WSL1 if we can, but we may just elect to require WSL2, I have updated our docs for now.

Is there any reason we really should support WSL1? As that will sway our choices.

@vladdeSV
Copy link
Author

Some points that speak for supporting WSL1:

@mxcl
Copy link
Member

mxcl commented Apr 1, 2023

WSL1 is the default

This is a pretty good reason lol. K we gotta support WSL1. Sounds like WSL2 is not mature or recommended yet.

@jhheider
Copy link
Contributor

jhheider commented Apr 1, 2023

I don't think this is still true:

https://learn.microsoft.com/en-us/windows/wsl/install

New Linux installations, installed using the wsl --install command, will be set to WSL 2 by default.

The wsl --set-version command can be used to downgrade from WSL 2 to WSL 1 or to update previously installed Linux distributions from WSL 1 to WSL 2.

To see whether your Linux distribution is set to WSL 1 or WSL 2, use the command: wsl -l -v.

To change versions, use the command: wsl --set-version <distro name> 2 replacing <distro name> with the name of the Linux distribution that you want to update. For example, wsl --set-version Ubuntu-20.04 2 will set your Ubuntu 20.04 distribution to use WSL 2.

That said, it's easy to have a WSL 1 install, either on an older Windows, predating the new default, or by "downgrading".

Notably: https://learn.microsoft.com/en-us/windows/wsl/compare-versions#comparing-features

It looks like WSL1 neither has a full Linux kernel, nor the full syscall availability. That might mean it needs to be built as its own binary variant. It looks like even rust has issues with WSL1, which likely means both deno and tea will as well.

@mxcl
Copy link
Member

mxcl commented Apr 2, 2023

k well if WSL2 is the current default then that needs supporting firstly. Do we work with WSL2? I have a windows machine so I should check this out myself.

@vladdeSV
Copy link
Author

vladdeSV commented Apr 2, 2023

I've had no problems with tea and WSL2 so far, been using for a month or so.

@jhheider
Copy link
Contributor

jhheider commented Apr 2, 2023

Yes, we've have no noteworthy bug reports for WSL2, given its reasonable similarity to a dockerized environment.

@mxcl mxcl added the enhancement New feature or request label Jun 7, 2023
@mxcl mxcl mentioned this issue Jun 7, 2023
6 tasks
@mxcl
Copy link
Member

mxcl commented Jun 8, 2023

Closing in lieu of #607

@mxcl mxcl closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants