-
Notifications
You must be signed in to change notification settings - Fork 33
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming for "xtol" and "ftol" criteria in PINTS (max_unchanged_iterations) #1509
Comments
Honestly speaking the name |
I have been using scipy optimisation, and Although I do agree, |
Thank you Michael for working on this! I may be alone on this, but I actually find the So, I am wondering whether Looking forward to hearing your thoughts! :) |
I'd avoid being too similar to the ftol and xtol (or xatol and fatol) standards as I think they carry the implication of checking with the previous iteration rather than the default in pints of 200 iterations ago.
I like the idea of keeping it all isolated to a single function. Makes it clear that if you're using multiple termination criteria then they should stack rather than override each other. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
As part of #1502 I'm wondering what to do about the names of the stopping criteria based on a minimum change per iteration
At the moment we have
set_max_unchanged_iterations
, which sets anftol
type criterion (stop when the best function value changes by less than X for N iterations). I'm adding one that sets anxtol
type criterion (stop when the best parameter value changes by less than X for N iterations). Current names in some software:I'd gone for
unmoved_iterations
but initial feedback says no. So now thinking we (deprecate and) rename theunchanged_iterations
methods to something that includes the word function?The text was updated successfully, but these errors were encountered: