-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save State #10
Comments
I dont know how I would do this either, so appreciate feedback or pointers on how to do this. |
A periodic save would definitely be good to have. It was probably just an oversight on my part that it doesn't currently do so. Current thinking is that plugins can start timers which run in separate threads, so we could probably use that to save state. |
The state should be saved anytime a savable plugin attribute is updated. Otherwise there is a risk of state rollback if the bot terminates unexpectedly. I've added this as a one-off to some of our internal plugins but it should really be implemented in BasePlugin I think. I'll try to work on this sometime soon. |
https://github.com/arcticfoxnv/slackminion/blob/e22601353f82ea2395a32933f4c2355374957d0b/slackminion/bot.py#L137
Thoughts?
The text was updated successfully, but these errors were encountered: