From 990d97e76986c764ef59d406259a8b63ac74a715 Mon Sep 17 00:00:00 2001 From: Daniel Townsend Date: Wed, 26 Jul 2023 17:57:22 +0100 Subject: [PATCH] fix assertions --- tests/columns/foreign_key/test_attribute_access.py | 9 +++++---- tests/columns/foreign_key/test_foreign_key_string.py | 4 ++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/columns/foreign_key/test_attribute_access.py b/tests/columns/foreign_key/test_attribute_access.py index c658d7d98..87caeb78e 100644 --- a/tests/columns/foreign_key/test_attribute_access.py +++ b/tests/columns/foreign_key/test_attribute_access.py @@ -21,7 +21,8 @@ class BandB(Table): class BandC(Table): manager = ForeignKey( references=LazyTableReference( - table_class_name="Manager", module_path=__name__ + table_class_name="Manager", + module_path=__name__, ) ) @@ -37,7 +38,7 @@ def test_attribute_access(self): references. """ for band_table in (BandA, BandB, BandC, BandD): - self.assertTrue(isinstance(band_table.manager.name, Varchar)) + self.assertIsInstance(band_table.manager.name, Varchar) def test_recursion_limit(self): """ @@ -47,7 +48,7 @@ def test_recursion_limit(self): # Should be fine: column: Column = Manager.manager.name self.assertTrue(len(column._meta.call_chain), 1) - self.assertTrue(isinstance(column, Varchar)) + self.assertIsInstance(column, Varchar) with self.assertRaises(Exception): Manager.manager.manager.manager.manager.manager.manager.manager.manager.manager.manager.manager.name # noqa @@ -59,4 +60,4 @@ def test_recursion_time(self): start = time.time() Manager.manager.manager.manager.manager.manager.manager.name end = time.time() - self.assertTrue(end - start < 1.0) + self.assertLess(end - start, 1.0) diff --git a/tests/columns/foreign_key/test_foreign_key_string.py b/tests/columns/foreign_key/test_foreign_key_string.py index 38d9e6bee..1dd8e3aee 100644 --- a/tests/columns/foreign_key/test_foreign_key_string.py +++ b/tests/columns/foreign_key/test_foreign_key_string.py @@ -33,7 +33,7 @@ class TestForeignKeyString(TestCase): def test_foreign_key_string(self): for band_table in (BandA, BandB, BandC): - self.assertEqual( + self.assertIs( band_table.manager._foreign_key_meta.resolved_references, Manager, ) @@ -66,4 +66,4 @@ def test_lazy_reference_to_app(self): table_class_name="Manager", app_name="music" ) - self.assertTrue(reference.resolve() is Manager) + self.assertIs(reference.resolve(), Manager)