Spies do not register as allowed method calls when stubbing is specified

[ciaranmcnulty]

Normally Spied-on methods are included in the list of expected calls. However, this breaks if stubbing takes place beforehand

Spec:

class SpiesExampleSpec extends ObjectBehavior
{
    function it_does_not_expect_spied_on_methods(\DateTime $time)
    {
        $time->getOffset()->willReturn(-1800);

        $this->modifyTimestamp($time);

        $time->setTimestamp(1234)->shouldHaveBeenCalled();
    }
}

Object:

class SpiesExample
{
    public function modifyTimestamp(\DateTime $time)
    {
        $time->getOffset();
        $time->setTimestamp(1234);
    }
}

Output:

  10  ! it does not expect spies
      method call:
        Double\DateTime\P1->setTimestamp(1234)
      was not expected.
      Expected calls are:
        - getOffset()

[ciaranmcnulty]

The Mock version passes as expected:

    function it_does_not_expect_spies(\DateTime $time)
    {
        $time->getOffset()->willReturn(-1800);
        $time->setTimestamp(1234)->shouldBeCalled();

        $this->modifyTimestamp($time);
    }

[stof]

can you run composer show -i phpspec/prophecy to see which version of Prophecy you use ?

[ciaranmcnulty]

phpspec/phpspec dev-master 5520c91
phpspec/prophecy v1.2.0

[ciaranmcnulty]

Bumping prophecy to dev-master shows the same result

[ciaranmcnulty]

To be clear, this version works fine:

Spec:

class SpiesExampleSpec extends ObjectBehavior
{
    function it_does_not_expect_spied_on_methods(\DateTime $time)
    {
        $this->modifyTimestamp($time);

        $time->setTimestamp(1234)->shouldHaveBeenCalled();
    }
}

Object:

class SpiesExample
{
    public function modifyTimestamp(\DateTime $time)
    {
        $time->setTimestamp(1234);
    }
}

It seems to be the mixture of stubs + spies

[stof]

ok, this looks like a really weird bug

[ciaranmcnulty]

From here:
https://github.com/phpspec/prophecy/blob/master/src/Prophecy/Call/CallCenter.php#L72-L82

It looks like at call time there will be an exception if the method is not mocked or stubbed, unless there are zero mocks/stubs.

[ciaranmcnulty]

Fixing it would involve moving that check to much later in the process

[stof]

but then, how could it pass in the second case ?

[ciaranmcnulty]

Which case is the second case?

• Spy only: https://github.com/phpspec/prophecy/blob/master/src/Prophecy/Call/CallCenter.php#L64-L69 means if no stubs/mocks exist on an object, any calls are valid
• Stub + Spy: Stubbed method is the only one allowed, invoking the Spied method raises an Exception
• Stub + Mock: Stubbed method and Mocked method are both allowed

[stof]

@everzet do you have an idea to fix this ?

[ciaranmcnulty]

I would say record the calls and evaluate whether they were expected or not later on rather than immediately.

Or turn off the 'expected call' checking and just return null for unexpected ones (trolling Konstantin now) ;-)

[MPV]

I just ran in to this issue as well (I have a stub that I expect a method to be called on, but shouldHaveBeenCalled() gives the error that @ciaranmcnulty mentioned).

[scaytrase]

Any news on this bug here in 2019?

[jdreesen]

Can this be closed, now that #441 is merged?