Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed package versions in requirements #21

Open
DominikFilipiak opened this issue Oct 24, 2024 · 2 comments
Open

Detailed package versions in requirements #21

DominikFilipiak opened this issue Oct 24, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@DominikFilipiak
Copy link

Some packages are loosely defined in the requirements. For example, matplotlib does not have an upper boundary for its version. With 3.9.4 running panda.teach(panda.qz) from the README will open a window, but the sliders will be unusable. Downgrading Matplotlib to 3.8.6 solved this problem for me, but I expect that we will encounter more in the future. For some of my students the interactive three angles demo doesn't work and we're not sure why - probably some other version mismatches.

Therefore, can we ask for the detailed packages version? Event a dump of pip freeze will be helpful here, I can take care of tidying it up and making PR.

@DominikFilipiak DominikFilipiak added the bug Something isn't working label Oct 24, 2024
@petercorke
Copy link
Owner

petercorke commented Oct 24, 2024 via email

@DominikFilipiak
Copy link
Author

DominikFilipiak commented Oct 25, 2024

I'd say we should cap all packages, as we can only expect more of such problems in the future. Providing exact package versions will prevent these.

This way users can make their environments with battle-tested packages on a specific python version and if an end user wants to have newer libraries that can be done in a separate virtual environment. After all, that's why they were invented. So I'd not fear submitting pip freeze. We can, however, explicitly suggest to install RVC tool in a separate venv.

PS. For Jupyter animations, I also needed to write my own function (eg. in chapter 2 notebook):

def tranimate2(T, **kwargs) -> str:
    dim = kwargs.pop("dims", None)
    ax = kwargs.pop("ax", None)
    anim = Animate(ax=ax, **kwargs)
    anim.trplot(T, **kwargs)
    return anim.run(**kwargs)

It was the dim/dims which yielded the error in the original code.

PPS. I really appreciate all the work you have done. It is a wonderful teaching material for introductory robotics course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants