Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

McBreadcrumbsConfig.postProcess nullable #18

Open
XavierDupessey opened this issue Jun 27, 2018 · 0 comments
Open

McBreadcrumbsConfig.postProcess nullable #18

XavierDupessey opened this issue Jun 27, 2018 · 0 comments

Comments

@XavierDupessey
Copy link

Hello,

I think the definition of McBreadcrumbsConfig.postProcess should be IPostProcessFunc | null | undefined to be able to reset it without Typescript compilation error.

A workaround is to assign an empty function but it's a shame: the code actually works with null or undefined.

I can make a PR if you agree but I think it will be longer to review it rather than changing it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant