Fixed Webpack/AMD support #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could a maintainer please suggest what is wrong with the pull request? The CI build has failed, but I'm having trouble deciphering the output. Unit tests ( |
This change enables converting values containing special characters, such as the percent sign (%), to strings, by always encoding values for which the check if encoding is actually necessary has failed. For values containing URI escape characters, the check throws an error (because they are not decodable), but we still need to encode them. Fixes persvr#75
This also includes a refactoring of the query module's `encodeValue` function for clarity and easier modification later, if necessary. Comments included. For persvr#76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to use rql with webpack. It adds a dependency on amdefine to package.json to avoid implementing the shims manually in every file. Tested under Node 6.0 and Webpack 1.13.0.
Fixes #69 .