Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing data for "Caribbean Netherlands" #156

Open
arvindkartik opened this issue Feb 27, 2019 · 3 comments
Open

Missing data for "Caribbean Netherlands" #156

arvindkartik opened this issue Feb 27, 2019 · 3 comments

Comments

@arvindkartik
Copy link

"id": 136251281,
"name": "Caribbean Netherlands",
"placetype": "dependency",

There is no short name/abbr present in the DB even though the data is present in WhosOnFirst.

@missinglink
Copy link
Member

Hi @arvindkartik,

The record 136251281 is available in the latest placeholder build as seen here:
https://parser.synergy.io/demo/#eng

You are correct in saying that there is no abbreviation, what were you expecting to see?

@rocainunwired
Copy link

Hi @missinglink , When i checked for other dependencies, like

"id": 85632731,
"name": "Bermuda",
"abbr": "BMU",
we do get a 3 digit abbreviation for them.

Caribbean Netherlands consists of three places (Bonaire, Sint Eustatius and Saba) all of which have the same ISO code "BES". So for Caribbean Netherlands maybe we can have a "abbr": "BES". Or we can go by the parent empire (Netherlands) and can make it "NL" or "NLD". Though "BES" is the correct value

@missinglink
Copy link
Member

I've opened a PR with the data provider here whosonfirst-data/whosonfirst-data#1498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants