-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adverserial tests #339
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The official BIP78 test vector checks the happy path where both the sender and receiver act honestly. To catch and prevent bugs that may result in loss of funds, we should add tests that uphold the sender/receiver checklists for when one of the parties behaves maliciously, e.g. tries to steal funds from the other. One such test was added here but it would be great to cover more (all?) code paths in the checklists.
If we can come up with good test vectors for these, maybe consider adding them to the BIP.
The text was updated successfully, but these errors were encountered: