Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Replace PlanTest equivalence with Ion rep. #1614

Open
RCHowell opened this issue Oct 8, 2024 · 0 comments
Open

[V1] Replace PlanTest equivalence with Ion rep. #1614

RCHowell opened this issue Oct 8, 2024 · 0 comments
Labels
V1 This is related to the V1 release of PartiQL.

Comments

@RCHowell
Copy link
Contributor

RCHowell commented Oct 8, 2024

Description

This issue is to track replacement of the PlanTest equivalence function (and pretty-printing) to use the Ion serde representation of plans. It currently uses the 0.14 pretty-print combined with data classes to get an equals/hashcode.

Now that the plan is a set of interfaces, we'll need a mechanism for comparing plans .. likely to be similar to the basic equivalence visitor.

https://github.com/partiql/partiql-lang-kotlin/blob/main/partiql-planner/src/test/kotlin/org/partiql/planner/util/PlanNodeEquivalentVisitor.kt#L16

@RCHowell RCHowell added the V1 This is related to the V1 release of PartiQL. label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V1 This is related to the V1 release of PartiQL.
Projects
None yet
Development

No branches or pull requests

1 participant